[18.0][MIG] hr_payroll_document: Migration to 18.0 #239
Conversation
Currently translated at 100.0% (32 of 32 strings) Translation: payroll-16.0/payroll-16.0-hr_payroll_document Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-hr_payroll_document/it/
|
Can you fix pre-commit first please @CristianoMafraJunior |
CristianoMafraJunior
force-pushed
the
18.0-mig-hr_payroll_document
branch
from
ad161d1 to
9b8294a
Compare
Done |
|
This PR has the |
SirPyTech
left a comment
SirPyTech
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I only reviewed the code, please see the comments.
chore: Please squash bot's commit according to https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate.
For example: 
|
|
||
| # Encrypt the payroll file with the identification identifier | ||
| # of the employee | ||
| pdfWriter.encrypt(employee.identification_id, algorithm="AES-256") |
There was a problem hiding this comment.
issue: Please retrieve the latest commits from 17.0.
For example: d85ad9b is missing.
Ideally, they should be in the correct point of the history: before the [MIG] commit.
There was a problem hiding this comment.
chore: Most of these changes should be in their own commit because they have been applied by pre-commit, please see the step
pre-commit run -a # to run pre-commit linters and formatters (please ignore pylint errors at this stage)
I recommend using https://github.com/OCA/odoo-module-migrator to automatically perform those steps.
7 participants
@Escodoo MIGOCA-16
cc @nimarosa @WesleyOliveira98 @kaynnan @marcelsavegnago